issue: 946914 Fix epoll_create() - libvma incompatibility with OS

OS does not support creating epoll fd's using epoll_create() with zero size. libvma should handle a non-positive size like OS does: return -1 and set the errno to EINVAL. Signed-off-by: Liran Oz <[email protected]>
Mellanox · Jan 9, 2017 · e25566b · e25566b
1 parent df2fff3
commit e25566b
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/vma/sock/sock-redirect.cpp b/src/vma/sock/sock-redirect.cpp
@@ -1798,6 +1798,12 @@ int epoll_create(int __size)
 
 	do_global_ctors();
 
+	if (__size <= 0 ) {
+		vlog_printf(VLOG_DEBUG, "%s: invalid size (size=%d) - must be a positive integer\n", __func__, __size);
+		errno = EINVAL;
+		return -1;
+	}
+
 	int epfd = orig_os_api.epoll_create(__size + 1);  // +1 for the cq epfd
 	vlog_printf(VLOG_DEBUG, "ENTER: %s(size=%d) = %d\n",__func__, __size, epfd);