Layers composable #348
Merged
Layers composable #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t component injection BREAKING CHANGE: These changes may not affect you directly. Previously, for some layer types, a layer was always added to the map, even if the layer component was used within a LayerGroup. This resulted in layers existing multiple times (in the LayerGroup and at the top level (Reported in #344)). Due to the refactoring, all layers are now treated the same (with onMounted and when changing layer properties). 1.) If the layer component is within an `ol-layer-group`, it is added to the group. 2.) If the layer component is inside an `ol-overviewmap-control`, it is added to the OverviewMap 3.) If 1) and 2) do not apply, the layer component is added directly to the map partially fixes #344
…-control` with `ol-layer-group`
✅ Deploy Preview for vue3openlayers ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of Changes
Checklist:
If you added a new component feature (layer, geom, source, etc.), please be sure to update the documentation:
output.globalsinvite.config.tstestdirectory)src/demos/<Component>Demo.vuedocs/componentsguide/<Category>/<Feature>/index.mdcontaining the Demo and documentation for the componentdocs/.vitepress/config.ts