Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FarmersDelightASM appears to be classloading class_1935 before the mixin processor starts #77

Open
1 of 2 tasks
unilock opened this issue Sep 1, 2024 · 2 comments
Open
1 of 2 tasks

Comments

@unilock
Copy link

unilock commented Sep 1, 2024

Minecraft version

1.20.1

Farmer's Delight version

2.1.4

Fabric Loader version

Quilt Loader 0.26.4-beta.5 (Fabric Loader 0.16.2)

Fabric API version

QFAPI 7.6.0 (Fabric API 0.92.2)

Description

I've noticed that net.minecraft.class_1935 (ItemConvertible / ItemLike) is being classloaded before the mixin processor starts. This can lead to weird issues with mixins not being applied to that class later on.

Apparently, this is due to Farmer's Delight Refabricated.

[53.781s][info][class,load] vectorwing.farmersdelight.FarmersDelightASM source: quilt.zfs://farmersdelight-1.20.1-2.1.4refabricated.i0:0/
[53.781s][info][class,load] net.minecraft.class_1935 source: quilt.zfs://minecraft-1.20.1.i0:0/

Though I'm not entirely sure what in FarmersDelightASM is causing this issue... it probably has something to do with a synthetic method created by a lambda. I don't have the bytecode in front of me.

Steps to reproduce

  1. Start the game

Mod list

  • Fabric API
  • Farmer's Delight Refabricated

Logs

N/A

Minimal instance

  • I have tested this on a minimal instance

Performance and shader mods

  • I am using performance or shader mods
@MerchantPug
Copy link
Collaborator

MerchantPug commented Sep 1, 2024

Mhm, I'll look into a fix for this when I get to making more fixes for 1.20.1, thanks for the report.

@MerchantPug
Copy link
Collaborator

MerchantPug commented Nov 7, 2024

I think that the true fix would be to either

a. remove recipe book code and enum extensions. This is a solution that others may find negligible, but as somebody who believes that with Farmer's Delight being a simple vanilla-like mod quite benefits from the recipe book as a thing for players who are less familiar with modded, this isn't ideal for me.
b. implement a custom recipe book menu/screen handler. I'm definitely going to look into this for my own mods, so I'd imagine refabricated could borrow from my own findings here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants