Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farmer's Delight Refrabricated and Mr Crayfish's Furniture Mod Refurbished crash #120

Closed
SAPH3RE opened this issue Jul 27, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@SAPH3RE
Copy link

SAPH3RE commented Jul 27, 2024

I was told to specifically bring the issue here as well, so here's the crash log of the incidence with porting lib.
crash-2024-07-27_14.10.58-client.txt

@MerchantPug
Copy link

MerchantPug commented Jul 27, 2024

This was apparently fixed in this commit.
MrCrayfish/MrCrayfishFurnitureMod-Refurbished@33423a8

However, my guess is that the issue lies in Porting Lib's Recipe Book API not liking it when two mods implement it.

@TropheusJ
Copy link
Member

What does this have to do with Porting Lib? ItemStack.getRecipeRemainder() is implemented by Fabric API.

@MerchantPug
Copy link

MerchantPug commented Jul 27, 2024

What does this have to do with Porting Lib? ItemStack.getRecipeRemainder() is implemented by Fabric API.

Yes, that is the case, but the crash was exposed through Porting Lib's Recipe Book API being used by both of the two mods in question. I'm genuinely really unsure what's going on here though.

Crayfish fixed it by removing the usage of that module, but ideally, we figure out what's going on.

@IThundxr IThundxr added the bug Something isn't working label Nov 5, 2024
@TropheusJ
Copy link
Member

This doesn't have anything to do with porting lib or the recipe book api. Fabric API adds a method that the CookingPotRecipe references and it's not there somehow. I don't know how that's possible or what would cause it, but porting lib isn't involved.

@MerchantPug
Copy link

MerchantPug commented Dec 3, 2024

I'm going to guess that it's actually linked to this issue.
MehVahdJukaar/FarmersDelightRefabricated#77

A recipe book library that's decoupled from enums might be in order on my end.

@MerchantPug
Copy link

MerchantPug commented Dec 3, 2024

Still, not your issue. You are correct.

@TropheusJ
Copy link
Member

That issue looks correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants