Improved Force Gen Unit Substitution #5085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the `generateLance` methods to include the `allowsTanks` parameter to allow us to ensure Vees aren't substituted into environments they cannot survive. Enhanced logging and fallback mechanisms were also integrated to handle unit generation failures and substitutions more effectively.
Added a log statement to track force generation in the AtBDynamicScenarioFactory. This helps in identifying issues by providing insights into the creation of forces based on templates.
IllianiCBT
added
the
Force Generation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5085 +/- ##
=========================================
Coverage 10.42% 10.42%
- Complexity 6028 6036 +8
=========================================
Files 953 953
Lines 134113 134122 +9
Branches 19435 19434 -1
=========================================
+ Hits 13979 13988 +9
- Misses 118785 118789 +4
+ Partials 1349 1345 -4 ☔ View full report in Codecov by Sentry. |
Updated log statements to use clearer method calls for unit type and weight class names. Moved a log statement inside the appropriate condition block for better readability and context.
HammerGS
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
generateLancemethods to include theallowsTanksparameter to allow us to ensure Vees aren't substituted into environments they cannot survive.Enhanced logging and fallback mechanisms were also integrated to handle unit generation failures and substitutions more effectively.