Added TotalGenericBattleValue Tag to MUL Export
#5070
Merged
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the `saveTo` method in `EntityListFile` to include an optional generic battle value parameter. Added calculation and integration of generic battle value in `BriefingTab` when saving entity lists to files. This is hidden in MUL export as GBV is not meant to be user-facing. We include it here as a debugging tool.
IllianiCBT
added
the
Force Generation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5070 +/- ##
============================================
- Coverage 10.43% 10.43% -0.01%
- Complexity 6032 6041 +9
============================================
Files 952 953 +1
Lines 133878 134112 +234
Branches 19436 19435 -1
============================================
+ Hits 13976 13996 +20
- Misses 118560 118772 +212
- Partials 1342 1344 +2 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added calculation and integration of generic battle value in
BriefingTabwhen saving entity lists to MUL.This is hidden in MUL export as GBV is not meant to be user-facing. We include it here as a debugging tool.
Closes #5045
Requires MegaMek/megamek#6122