Prevent StratCon from Pulling in Player DropShips, when Option is Disabled #5046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
IllianiCBT
commented
Oct 14, 2024
•
IllianiCBT
commented
- Added a condition to check whether Use DropShips is enabled in AtB Options, before substituting NPC DropShips with Player DropShips.
- Fixed player DropShip substitution in FG3
…abled Added a condition to skip units if DropShip use is disabled in campaign options.
Changed the force generation method from 3 to 4 across multiple scenario templates. This modification affects the Isolated DropShip Defense, Space Blockade Run, Low-Atmosphere DropShip Escort, and Deep Raid Defense scenarios. The adjustment ensures consistency and may improve scenario balance or performance.
IllianiCBT
added
Bug
StratCon
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5046 +/- ##
============================================
- Coverage 10.43% 10.43% -0.01%
+ Complexity 6022 6021 -1
============================================
Files 952 952
Lines 133810 133883 +73
Branches 19432 19435 +3
============================================
+ Hits 13961 13966 +5
- Misses 118498 118574 +76
+ Partials 1351 1343 -8 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.