Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash09/steamlocate #47

Merged
merged 4 commits into from
Aug 26, 2023
Merged

Bash09/steamlocate #47

merged 4 commits into from
Aug 26, 2023

Conversation

Bash-09
Copy link
Contributor

@Bash-09 Bash-09 commented Aug 15, 2023

Change to use the steamlocate crate instead of manually trying to find it.

Will hopefully fix #45

@Bash-09 Bash-09 requested a review from lili7h August 15, 2023 11:34
@Bash-09 Bash-09 force-pushed the Bash09/steamlocate branch 2 times, most recently from 4918a2c to 5d437c0 Compare August 19, 2023 00:20
@Bash-09 Bash-09 requested a review from cgcha August 20, 2023 13:03
Copy link
Contributor

@cgcha cgcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to run fine on my windows machine without issue. I was getting the same warnings as listed here (WilliamVenner/steamlocate-rs#19) but changing the toml to include version 2.0.0-alpha.0 seemed to be functionally the same. We'll probably want to keep a lookout for when a stable release is made to replace it with.

src/launchoptions.rs Outdated Show resolved Hide resolved
@Bash-09 Bash-09 force-pushed the Bash09/steamlocate branch from da274b5 to b99f413 Compare August 26, 2023 05:18
@Bash-09 Bash-09 merged commit 95538ad into main Aug 26, 2023
@Bash-09 Bash-09 deleted the Bash09/steamlocate branch August 26, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection issues
2 participants