Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add arm64 fp16 rotate support #54

Merged
merged 2 commits into from
Oct 23, 2023
Merged

feat: Add arm64 fp16 rotate support #54

merged 2 commits into from
Oct 23, 2023

Conversation

violet73
Copy link
Contributor

Add arm64 fp16 rotate and test. OSPP project implementation.

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@violet73
Copy link
Contributor Author

根据OSPP的要求，提PR的邮箱需要和OSPP注册邮箱一致，因此新开此PR，内容与已关闭PR一致。

@Li-Ming-xin
Copy link
Collaborator

CI挂了，使用clang-format格式化一下你修改的文件试一下？ @violet73

@violet73
Copy link
Contributor Author

CI挂了，使用clang-format格式化一下你修改的文件试一下？ @violet73

Summary里显示是没有runners跑lint，如下图所示，这是什么原因？

image

@Li-Ming-xin
Copy link
Collaborator

CI挂了，使用clang-format格式化一下你修改的文件试一下？ @violet73

Summary里显示是没有runners跑lint，如下图所示，这是什么原因？

image

actions/runner-images#6002

Workflows using the ubuntu-18.04 image label should be updated to ubuntu-latest, ubuntu-20.04, or ubuntu-22.04

麻烦尝试更新.github/workflows/lint.yml，将ubuntu-18.04修改为ubuntu-20.04。

@Li-Ming-xin
Copy link
Collaborator

LGTM

@yeasoon yeasoon merged commit 0f16dbb into MegEngine:main Oct 23, 2023
3 checks passed
@yeasoon yeasoon added the merging Waiting for merge internally label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merging Waiting for merge internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@violet73 @CLAassistant @Li-Ming-xin @yeasoon