extract events from the discharged_concept_id field of the visit table with the correct time #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…act from for the event time
ChaoPang
changed the title
EthanSteinberg
approved these changes
Oct 28, 2024
src/meds_etl/omop.py
Outdated
| @@ -188,6 +194,8 @@ def write_event_data( | |||
| for option in options | |||
| if table_name + option in schema.names() | |||
| ] | |||
| # We prefer user defined time field options over the default time options if available | |||
There was a problem hiding this comment.
Why not:
options = table_details.get("time_field_options", []) + ["_start_datetime", "_start_date", "_datetime", "_date"]
options = [
cast_to_datetime(schema, table_name + option, move_to_end_of_day=True)
for option in options
if table_name + option in schema.names()
]
There was a problem hiding this comment.
@EthanSteinberg I like your suggestion cos it's concise. The fields defined in time_field_options already contain the table name e.g. visit_end_datetime and visit_end_date, I can change it to _end_datetime and _end_date so your suggestion would work, what do you think?
There was a problem hiding this comment.
Hmm. Yeah that would work. I would also be down with changing the code above to:
ptions = table_details.get("time_field_options", []) + [table_name + "_start_datetime", table_name + "_start_date", table_name + "_datetime", table_name + "_date"]
EthanSteinberg
approved these changes
Oct 31, 2024
|
@ChaoPang Simply merge this when you are ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to extract discharged_concept_id as a separate event from the visit table. This will be important for identifying hospital discharge events when using ACES.