Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract events from the discharged_concept_id field of the visit table #40

Merged

Conversation

ChaoPang
Copy link
Collaborator

@ChaoPang ChaoPang commented Oct 25, 2024

We want to extract discharged_concept_id as a separate event from the visit table. This will be important for identifying hospital discharge events to use ACES.

Copy link
Collaborator

@EthanSteinberg EthanSteinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you verify that this works? I think you need the file suffix thing for the discharged_to_concept_id field as well?

@ChaoPang
Copy link
Collaborator Author

ChaoPang commented Oct 25, 2024

@EthanSteinberg I ran this successfully on Columbia data, I didn't add file suffix because it uses the first table_details in the list to return all the files at https://github.com/Medical-Event-Data-Standard/meds_etl/blob/main/src/meds_etl/omop.py#L718, but I am happy to add the file_suffix to discharged_to_concept_id for consistency.

@EthanSteinberg
Copy link
Collaborator

EthanSteinberg commented Oct 25, 2024

Oh, I didn't know that it uses the first one. That's a bit confusing. Thanks for adding and testing this!

Feel free to merge whenever you are ready.

@ChaoPang ChaoPang merged commit 09532b8 into Medical-Event-Data-Standard:main Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants