GUI: fix double-free on capture stop/application exit

Signed-off-by: Maxime Gervais <[email protected]>
MediaArea · Apr 6, 2024 · 2bea63d · 2bea63d
1 parent 12ceda7
commit 2bea63d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/Source/GUI/dvrescue/dvrescue/mediaplayer.cpp b/Source/GUI/dvrescue/dvrescue/mediaplayer.cpp
@@ -256,7 +256,10 @@ void MediaPlayer::setBuffer(QIODevice* newBuffer)
 {
     if (m_buffer.get() == newBuffer)
         return;
-    m_buffer.reset(newBuffer);
+
+    m_buffer.reset(newBuffer, [](QObject*){}); // NoDeleter
+                                               // RAW pointer is owned by the QML engine
+                                               // and deleted outside of the shared pointer
 
     QSharedPointer<QAVIODevice> dev(new QAVIODevice(m_buffer));