Make number of classes per generated file configurable #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbean-bremen
approved these changes
Nov 17, 2023
| @@ -62,6 +62,7 @@ class GeneratorSetQtScript : public GeneratorSet | |||
|
|
|||
| private: | |||
| MetaQtScriptBuilder builder; | |||
| int maxClassesPerFile{30}; | |||
There was a problem hiding this comment.
I wonder if we should use a large number as default instead to make changes by default better comparable. I assume that the restriction had to do with limitations / performance issues with earlier compilers and IDEs, and I doubt that this is still needed nowadays. Would like to hear other opinions...
usiems
force-pushed
the
classes_per_file_argument
branch
from
07850a8 to
c6be9bf
Compare
|
I'm going to merge this as it is needed for the other PR. We can always change the default later. |
|
Actually it is the other PR which is needed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the --max-classes-per-file command line argument. The default for this is 30, as before.
The motivation for this is that comparing the output for different versions (of Qt or the generator) gets easier when everything is one file, so that added or removed classes don't change the output of subsequent files. For this purpose one can use
--max-classes-per-file=10000.