Qt5 latest workflow #151
Qt5 latest workflow #151
Conversation
There was a problem hiding this comment.
This looks good to me, thanks! One question (also to @iakov) - I wonder if it would make sense to use this as the default workflow, e.g. integrate it also into the other workflows?
.github/workflows/build_latest.yml
Outdated
| @@ -0,0 +1,77 @@ | |||
| name: Latest Qt5 | |||
There was a problem hiding this comment.
Maybe change the name to something like "Use generated code", as this is certainly not the latest Qt5. There are two othyer workflows (ubuntu 22.04 and WinGW 7.3) with Qt 5.15.
There was a problem hiding this comment.
Yes, there is some misunderstanding between "latest qt" and 5.12 :)
I will rename it to the more suitable form
.github/workflows/build_latest.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| qt-version: [ '5.12.*' ] |
There was a problem hiding this comment.
Now that the other branch is merged, you may try to add "5.15.*" to the matrix.
After discussion with @iakov, We don't think that it is needed for every qt version, moreover, it seems to be unneeded to check freshly generated code for qt less than 5.6 version, because these versions are not the LTS, not supported, and correctly generated_cpp, which are needed for PythonQt, are already in master. For the latest versions, especially for the LTS versions, it seems more reasonable to do a check. Thus, the task is to check the correctness of the new versions of the generator and the generating on the new versions of Qt, so a separate workflow for this seems to us a good idea |
|
Agreed. I still would like to see 5.15 added here, though. |
CI workflow for Qt5 latest builds on Ubuntu-latest worker based on #149.
Adds a new step that allows to build PythonQt with freshly generated code.
Now contains qt 5.12 version for testing a new scenario, but easily can be changed to 5.* (equivalent to 5.15) when PR #146 is merged.