Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for https://github.com/McStasMcXtrace/McCode/issues/1741 #1745

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

willend
Copy link
Contributor

@willend willend commented Oct 16, 2024

This in effect means:

  • Partial revert of f9c8442 and bc50576
  • Documenting that tth_sign only works together with d_phi

I further found that weigh corrections were not correctly applied with tth_sign, powder lines became a factor of 2 too strong.

@willend willend merged commit f81a33d into McStasMcXtrace:main Oct 16, 2024
16 checks passed
@farhi
Copy link
Contributor

farhi commented Oct 16, 2024

Thanks Peter, Would be nice to port as well to X-rays ???

@willend
Copy link
Contributor Author

willend commented Oct 16, 2024

Yup, I will have a look at that also.

@willend
Copy link
Contributor Author

willend commented Oct 16, 2024

(But may not happen until next week, so will simply keep the issue open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants