Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes in monitors #1533

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Small fixes in monitors #1533

merged 3 commits into from
Dec 7, 2023

Conversation

mads-bertelsen
Copy link
Contributor

Monitor_4PI
Wrong use of NAME_CURRENT_COMPONENT in save section fixed

TOFlog_monitor
Used static memory, moved to dynamic and removed static limit on memory

PSD_monitor_psf
Still had state and polarization parameters that would not compile

Small fixes in monitors:
0821fd8 
  Monitor_4PI
  Wrong use of NAME_CURRENT_COMPONENT in save section fixed

  TOFlog_monitor
  Used static memory, moved to dynamic and removed static limit on memory

  PSD_monitor_psf
  Still had state and polarization parameters that would not compile
@willend
Update TOFlog_monitor.comp
2a83351 
Arrays defined via create_darr*() are in fact calloc()'ed and hence no longer need the classic for-loop for 0-init.
@willend
Update PSD_monitor_psf.comp
dfa10b8 
This for-loop structure init is no longer needed as create_darr*() return calloc'ed arrays.
willend
willend approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@willend willend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all meaningful changes. I added two small commits removing the for-loops with 0-init, no longer needed with the use of create_darr*() routines.

(We should perhaps check if there are other monitors around that still perform that step.)

@willend willend merged commit f2b6c4e into main Dec 7, 2023
20 checks passed
@willend
Copy link
Contributor

willend commented Dec 7, 2023

I've removed remaining for-loop init's in 2a52e58. Now running integration test.

@willend willend deleted the small_monitors_fixes branch October 7, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willend willend willend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mads-bertelsen @willend