Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Desktop Version #156

Merged
merged 42 commits into from
Jan 10, 2025
Merged

Add Desktop Version #156

merged 42 commits into from
Jan 10, 2025

Conversation

camdnnn
Copy link
Contributor

@camdnnn camdnnn commented Dec 8, 2024

Adds the ability to create a standalone desktop version

@camdnnn camdnnn added enhancement New feature or request backend Involves the Java Quarkus backend. frontend Involves the React Typescript frontend. labels Dec 8, 2024
@camdnnn camdnnn self-assigned this Dec 8, 2024
@camdnnn camdnnn linked an issue Dec 8, 2024 that may be closed by this pull request
Copy link
Collaborator

@gr812b gr812b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very great that it works, lots of work went into this. Im a big antifan of the stuff within the frontend to make it work. As a developper, I shouldn't need to test my feature in electron to make sure it works, it should just work. If we need to look into other config stuff or approaches we can do so. Package stuff looks good just some things to clean up

front-end/src/electron/main.js Outdated Show resolved Hide resolved
front-end/src/components/Topbar/Topbar.tsx Outdated Show resolved Hide resolved
front-end/src/components/map/MapDisplay/MapDisplay.jsx Outdated Show resolved Hide resolved
front-end/.gitignore Outdated Show resolved Hide resolved
front-end/src/components/App.tsx Outdated Show resolved Hide resolved
front-end/src/electron/main.js Outdated Show resolved Hide resolved
front-end/src/lib/apiUtils.ts Outdated Show resolved Hide resolved
package.ps1 Outdated Show resolved Hide resolved
package.ps1 Show resolved Hide resolved
@camdnnn camdnnn added this to the Data Viewer 1.2 milestone Dec 11, 2024
@camdnnn camdnnn requested a review from gr812b December 12, 2024 19:53
@camdnnn camdnnn marked this pull request as ready for review December 12, 2024 19:53
Copy link
Collaborator

@gr812b gr812b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks very close to done and very clean. Will just comment since we'll merge after new changes

front-end/package.json Outdated Show resolved Hide resolved
front-end/package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe want to look at this file in terms of whether it applies any changes to typescript across most of the frontend as a whole. Was considering adding this for some of the linting stuff anyways

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, idrk. I made it seperate because I needed to perseve the file to make sure that I could path to it

@camdnnn camdnnn merged commit e06ccd1 into main Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Involves the Java Quarkus backend. enhancement New feature or request frontend Involves the React Typescript frontend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Offline Access
2 participants