-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Desktop Version #156
Add Desktop Version #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall very great that it works, lots of work went into this. Im a big antifan of the stuff within the frontend to make it work. As a developper, I shouldn't need to test my feature in electron to make sure it works, it should just work. If we need to look into other config stuff or approaches we can do so. Package stuff looks good just some things to clean up
backend/src/main/java/com/mcmasterbaja/binary_csv/BinaryToCSV.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks very close to done and very clean. Will just comment since we'll merge after new changes
front-end/tsconfig.main.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe want to look at this file in terms of whether it applies any changes to typescript across most of the frontend as a whole. Was considering adding this for some of the linting stuff anyways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, idrk. I made it seperate because I needed to perseve the file to make sure that I could path to it
Adds the ability to create a standalone desktop version