Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript Refactor (V2) #127

Merged
merged 20 commits into from
Oct 28, 2024
Merged

Typescript Refactor (V2) #127

merged 20 commits into from
Oct 28, 2024

Conversation

gr812b
Copy link
Collaborator

@gr812b gr812b commented Oct 1, 2024 •
edited
Loading

Adding typescript on the front end!

What was done:

  • Reconfigured vite to use typescript
  • Added typescript checking and linting
  • Simplified API return types
  • Converted chartInformation and Chart to typescript

TODO:

  • Centralize type definitions
  • Verify linting on front end (not just typeschecking)

gr812b
gr812b commented Oct 14, 2024
View reviewed changes
Copy link
Collaborator Author

@gr812b gr812b left a comment •
edited by hydrowoxy
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few places to touch 😈

front-end/src/components/views/Chart/Chart.tsx Outdated Show resolved Hide resolved
front-end/src/components/views/Chart/useChartData.tsx Outdated Show resolved Hide resolved
front-end/src/lib/videoUtils.ts Outdated Show resolved Hide resolved
front-end/tsconfig.node.json Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this?

@gr812b gr812b mentioned this pull request Oct 14, 2024
Closed
@gr812b gr812b added this to the Data Viewer 1.2 milestone Oct 14, 2024
@t-wing11
Copy link
Contributor

t-wing11 commented Oct 15, 2024 •
edited by camdnnn
Loading

Why are there still jsx files in the repo, was there a reason why u had to leave them as they were?

I love oppais (anime tiddies) btw >_<

@gr812b
Copy link
Collaborator Author

gr812b commented Oct 17, 2024

@t-wing11 Those are the ones that will be left for later, not messing with them as the UI / UX will most likely have a heavy impact. It also helps reduce the scope of this PR, so something like the map functionality can be done elsewhere, which lets the review of this one focus better

camdnnn
camdnnn reviewed Oct 25, 2024
View reviewed changes
front-end/src/components/modal/upload/UploadModal.jsx

ApiUtil.uploadFile(fileLists[i]);
if (i===fileLists.length-1) {
resolve();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are files that would previously been rejected now handled?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used to reject in the promise, now it throws the error application wide. Temporary solution until we improve front end error handling, as all other methods do the same thing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#125

camdnnn
camdnnn reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@camdnnn camdnnn left a comment •
edited by hydrowoxy
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuck you all! I--it's not like I wanted to review your PR or anything... kyaaa!!! >///<

hydrowoxy
hydrowoxy reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@hydrowoxy hydrowoxy left a comment •
edited by camdnnn
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuck you cam

@gr812b
Copy link
Collaborator Author

gr812b commented Oct 25, 2024 •
edited by camdnnn
Loading

Fuck you cam

☹️ Salama how could you say that!!!!!!!

@gr812b gr812b merged commit 0cae8bf into main Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hydrowoxy hydrowoxy hydrowoxy left review comments

@camdnnn camdnnn camdnnn left review comments

@JAWalmsley JAWalmsley JAWalmsley approved these changes

@t-wing11 t-wing11 Awaiting requested review from t-wing11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Data Viewer 1.2
Development

Successfully merging this pull request may close these issues.
5 participants
@gr812b @t-wing11 @JAWalmsley @camdnnn @hydrowoxy