Lint

McMaster-Baja-Racing · Jan 2, 2025 · 94e3d66 · 94e3d66
1 parent 554963a
commit 94e3d66
Show file tree

Hide file tree

Showing 16 changed files with 104 additions and 169 deletions.
diff --git a/backend/src/main/java/com/mcmasterbaja/ExceptionMappers.java b/backend/src/main/java/com/mcmasterbaja/ExceptionMappers.java
@@ -1,10 +1,5 @@
 package com.mcmasterbaja;
 
-import java.util.UUID;
-
-import org.jboss.logging.Logger;
-import org.jboss.resteasy.reactive.server.ServerExceptionMapper;
-
 import com.mcmasterbaja.exceptions.AnalyzerException;
 import com.mcmasterbaja.exceptions.InvalidArgumentException;
 import com.mcmasterbaja.exceptions.InvalidColumnException;
@@ -13,29 +8,31 @@
 import com.mcmasterbaja.exceptions.InvalidOutputFileException;
 import com.mcmasterbaja.exceptions.StorageException;
 import com.mcmasterbaja.model.ErrorResponse;
-
 import jakarta.inject.Inject;
 import jakarta.ws.rs.core.MediaType;
 import jakarta.ws.rs.core.Response;
+import java.util.UUID;
+import org.jboss.logging.Logger;
+import org.jboss.resteasy.reactive.server.ServerExceptionMapper;
 
 // Exceptions are mapped in priority of most specific first
 public class ExceptionMappers {
 
-  @Inject
-  Logger logger;
+  @Inject Logger logger;
 
   // Handles invalid arguments
-  @ServerExceptionMapper(value = { InvalidArgumentException.class })
+  @ServerExceptionMapper(value = {InvalidArgumentException.class})
   public Response invalidArgument(RuntimeException e) {
     String errorId = UUID.randomUUID().toString();
     logger.error("errorId[{}]", errorId, e);
 
-    ErrorResponse errorResponse = new ErrorResponse(
-        errorId,
-        e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
-        "An invalid argument was passed.",
-        "INVALID_ARGUMENT",
-        e.getMessage());
+    ErrorResponse errorResponse =
+        new ErrorResponse(
+            errorId,
+            e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
+            "An invalid argument was passed.",
+            "INVALID_ARGUMENT",
+            e.getMessage());
 
     return Response.status(Response.Status.BAD_REQUEST)
         .entity(errorResponse)
@@ -49,12 +46,13 @@ public Response invalidColumn(InvalidColumnException e) {
     String errorId = UUID.randomUUID().toString();
     logger.error("errorId[{}]", errorId, e);
 
-    ErrorResponse errorResponse = new ErrorResponse(
-        errorId,
-        e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
-        "An invalid column was specified.",
-        "INVALID_COLUMN",
-        e.getMessage());
+    ErrorResponse errorResponse =
+        new ErrorResponse(
+            errorId,
+            e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
+            "An invalid column was specified.",
+            "INVALID_COLUMN",
+            e.getMessage());
 
     return Response.status(Response.Status.BAD_REQUEST)
         .entity(errorResponse)
@@ -68,12 +66,13 @@ public Response headerException(InvalidHeaderException e) {
     String errorId = UUID.randomUUID().toString();
     logger.error("errorId[{}]", errorId, e);
 
-    ErrorResponse errorResponse = new ErrorResponse(
-        errorId,
-        e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
-        "Failed to read headers from input file.",
-        "HEADER_ERROR",
-        e.getMessage());
+    ErrorResponse errorResponse =
+        new ErrorResponse(
+            errorId,
+            e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
+            "Failed to read headers from input file.",
+            "HEADER_ERROR",
+            e.getMessage());
 
     return Response.status(Response.Status.BAD_REQUEST)
         .entity(errorResponse)
@@ -87,12 +86,13 @@ public Response invalidInputFile(InvalidInputFileException e) {
     String errorId = UUID.randomUUID().toString();
     logger.error("errorId[{}]", errorId, e);
 
-    ErrorResponse errorResponse = new ErrorResponse(
-        errorId,
-        e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
-        "An invalid input file was specified.",
-        "INVALID_INPUT_FILE",
-        e.getMessage());
+    ErrorResponse errorResponse =
+        new ErrorResponse(
+            errorId,
+            e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
+            "An invalid input file was specified.",
+            "INVALID_INPUT_FILE",
+            e.getMessage());
 
     return Response.status(Response.Status.BAD_REQUEST)
         .entity(errorResponse)
@@ -106,12 +106,13 @@ public Response invalidOutputFile(InvalidOutputFileException e) {
     String errorId = UUID.randomUUID().toString();
     logger.error("errorId[{}]", errorId, e);
 
-    ErrorResponse errorResponse = new ErrorResponse(
-        errorId,
-        e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
-        "An invalid output file was specified.",
-        "INVALID_OUTPUT_FILE",
-        e.getMessage());
+    ErrorResponse errorResponse =
+        new ErrorResponse(
+            errorId,
+            e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
+            "An invalid output file was specified.",
+            "INVALID_OUTPUT_FILE",
+            e.getMessage());
 
     return Response.status(Response.Status.BAD_REQUEST)
         .entity(errorResponse)
@@ -125,12 +126,13 @@ public Response mapStorageException(StorageException e) {
     String errorId = UUID.randomUUID().toString();
     logger.error("errorId[{}]", errorId, e);
 
-    ErrorResponse errorResponse = new ErrorResponse(
-        errorId,
-        e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
-        "Something went wrong. It's probably your fault.",
-        "STORAGE_EXCEPTION",
-        e.getMessage());
+    ErrorResponse errorResponse =
+        new ErrorResponse(
+            errorId,
+            e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
+            "Something went wrong. It's probably your fault.",
+            "STORAGE_EXCEPTION",
+            e.getMessage());
 
     return Response.status(500).entity(errorResponse).type(MediaType.APPLICATION_JSON).build();
   }
@@ -141,12 +143,13 @@ public Response mapAnalyzerException(AnalyzerException e) {
     String errorId = UUID.randomUUID().toString();
     logger.error("errorId[{}]", errorId, e);
 
-    ErrorResponse errorResponse = new ErrorResponse(
-        errorId,
-        e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
-        "An error occurred with the analyzer.",
-        "ANALYZER_ERROR",
-        e.getMessage());
+    ErrorResponse errorResponse =
+        new ErrorResponse(
+            errorId,
+            e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
+            "An error occurred with the analyzer.",
+            "ANALYZER_ERROR",
+            e.getMessage());
 
     return Response.status(500).entity(errorResponse).type(MediaType.APPLICATION_JSON).build();
   }
@@ -156,12 +159,13 @@ public Response mapUnsatisfiedLink(UnsatisfiedLinkError e) {
     String errorId = UUID.randomUUID().toString();
     logger.error("errorId[{}]", errorId, e);
 
-    ErrorResponse errorResponse = new ErrorResponse(
-        errorId,
-        e.getStackTrace()[6].getClassName() + "." + e.getStackTrace()[6].getMethodName(),
-        "Failed to link to parser library. Might need to restart the backend.",
-        "UNSATISFIED_LINK_ERROR",
-        e.getMessage());
+    ErrorResponse errorResponse =
+        new ErrorResponse(
+            errorId,
+            e.getStackTrace()[6].getClassName() + "." + e.getStackTrace()[6].getMethodName(),
+            "Failed to link to parser library. Might need to restart the backend.",
+            "UNSATISFIED_LINK_ERROR",
+            e.getMessage());
 
     return Response.status(500).entity(errorResponse).type(MediaType.APPLICATION_JSON).build();
   }
@@ -171,13 +175,14 @@ public Response mapUnsatisfiedLink(NoClassDefFoundError e) {
     String errorId = UUID.randomUUID().toString();
     logger.error("errorId[{}]", errorId, e);
 
-    ErrorResponse errorResponse = new ErrorResponse(
-        errorId,
-        e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
-        "Failed to link to parser library. Probably need to restart your backend, live reload"
-            + " for the parser does not work.",
-        "UNSATISFIED_LINK_ERROR",
-        e.getMessage());
+    ErrorResponse errorResponse =
+        new ErrorResponse(
+            errorId,
+            e.getStackTrace()[0].getClassName() + "." + e.getStackTrace()[0].getMethodName(),
+            "Failed to link to parser library. Probably need to restart your backend, live reload"
+                + " for the parser does not work.",
+            "UNSATISFIED_LINK_ERROR",
+            e.getMessage());
 
     return Response.status(500).entity(errorResponse).type(MediaType.APPLICATION_JSON).build();
   }

diff --git a/backend/src/main/java/com/mcmasterbaja/FileAnalyzeResource.java b/backend/src/main/java/com/mcmasterbaja/FileAnalyzeResource.java
@@ -1,13 +1,5 @@
 package com.mcmasterbaja;
 
-import java.io.File;
-import java.nio.file.Path;
-import java.nio.file.Paths;
-
-import org.jboss.logging.Logger;
-import org.jboss.resteasy.reactive.RestResponse;
-import org.jboss.resteasy.reactive.RestResponse.ResponseBuilder;
-
 import com.mcmasterbaja.analyzer.Analyzer;
 import com.mcmasterbaja.analyzer.AnalyzerFactory;
 import com.mcmasterbaja.annotations.OnAnalyzerException;
@@ -17,14 +9,19 @@
 import com.mcmasterbaja.model.MinMax;
 import com.mcmasterbaja.services.FileMetadataService;
 import com.mcmasterbaja.services.StorageService;
-
 import jakarta.inject.Inject;
 import jakarta.ws.rs.BeanParam;
 import jakarta.ws.rs.GET;
 import jakarta.ws.rs.PATCH;
 import jakarta.ws.rs.POST;
 import jakarta.ws.rs.PathParam;
 import jakarta.ws.rs.QueryParam;
+import java.io.File;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import org.jboss.logging.Logger;
+import org.jboss.resteasy.reactive.RestResponse;
+import org.jboss.resteasy.reactive.RestResponse.ResponseBuilder;
 
 @jakarta.ws.rs.Path("/")
 public class FileAnalyzeResource {
@@ -88,9 +85,9 @@ public Boolean toggleLive() {
       Serial.exit = true;
     } else {
       new Thread(
-          () -> {
-            Serial.readLive();
-          })
+              () -> {
+                Serial.readLive();
+              })
           .start();
     }
 

diff --git a/backend/src/main/java/com/mcmasterbaja/FileFetchResource.java b/backend/src/main/java/com/mcmasterbaja/FileFetchResource.java
@@ -1,7 +1,7 @@
 package com.mcmasterbaja;
 
-import com.mcmasterbaja.exceptions.InvalidInputFileException;
 import com.mcmasterbaja.exceptions.FileNotFoundException;
+import com.mcmasterbaja.exceptions.InvalidInputFileException;
 import com.mcmasterbaja.model.FileInformation;
 import com.mcmasterbaja.model.FileTimespan;
 import com.mcmasterbaja.services.FileMetadataService;

diff --git a/backend/src/main/java/com/mcmasterbaja/analyzer/AccelCurveAnalyzer.java b/backend/src/main/java/com/mcmasterbaja/analyzer/AccelCurveAnalyzer.java
@@ -3,7 +3,6 @@
 import com.mcmasterbaja.annotations.OnAnalyzerException;
 import com.mcmasterbaja.model.AnalyzerParams;
 import com.mcmasterbaja.model.AnalyzerType;
-import com.opencsv.exceptions.CsvException;
 import jakarta.enterprise.context.Dependent;
 import jakarta.inject.Inject;
 import java.io.BufferedWriter;
@@ -14,8 +13,6 @@
 import java.util.Arrays;
 import java.util.List;
 import lombok.SneakyThrows;
-
-
 import org.jboss.logging.Logger;
 
 @Dependent
@@ -30,8 +27,8 @@ public class AccelCurveAnalyzer extends Analyzer {
   // outputFiles are first primary RPM rolling average, then secondary RPM rolling average, then
   // interpolated, then accel curve (runs)
   @Override
-@SneakyThrows  
-public void analyze(AnalyzerParams params) {
+  @SneakyThrows
+  public void analyze(AnalyzerParams params) {
     extractParams(params);
     logger.info("Combining \"" + inputFiles[0] + "\" and \"" + inputFiles[1] + "\"");
     logger.info("sGolay Averaging...");

diff --git a/backend/src/main/java/com/mcmasterbaja/analyzer/AverageAnalyzer.java b/backend/src/main/java/com/mcmasterbaja/analyzer/AverageAnalyzer.java
@@ -1,14 +1,14 @@
 package com.mcmasterbaja.analyzer;
 
 import com.mcmasterbaja.annotations.OnAnalyzerException;
-import com.opencsv.CSVReader;
-import com.opencsv.ICSVWriter;
-import java.util.List;
-import lombok.SneakyThrows;
 import com.mcmasterbaja.model.AnalyzerParams;
 import com.mcmasterbaja.model.AnalyzerType;
+import com.opencsv.CSVReader;
+import com.opencsv.ICSVWriter;
 import jakarta.enterprise.context.Dependent;
 import jakarta.inject.Inject;
+import java.util.List;
+import lombok.SneakyThrows;
 import org.jboss.logging.Logger;
 
 @Dependent

diff --git a/backend/src/main/java/com/mcmasterbaja/analyzer/BullshitAnalyzer.java b/backend/src/main/java/com/mcmasterbaja/analyzer/BullshitAnalyzer.java
@@ -2,14 +2,12 @@
 
 import com.mcmasterbaja.annotations.OnAnalyzerException;
 import com.mcmasterbaja.exceptions.InvalidHeaderException;
+import com.mcmasterbaja.model.AnalyzerParams;
 import com.opencsv.CSVReader;
 import com.opencsv.ICSVWriter;
-import lombok.SneakyThrows;
-
-
-import com.mcmasterbaja.model.AnalyzerParams;
 import jakarta.enterprise.context.Dependent;
 import jakarta.inject.Inject;
+import lombok.SneakyThrows;
 import org.jboss.logging.Logger;
 
 @Dependent

diff --git a/backend/src/main/java/com/mcmasterbaja/analyzer/ConstantAdderAnalyzer.java b/backend/src/main/java/com/mcmasterbaja/analyzer/ConstantAdderAnalyzer.java
@@ -2,19 +2,13 @@
 
 import com.mcmasterbaja.annotations.OnAnalyzerException;
 import com.mcmasterbaja.exceptions.InvalidHeaderException;
-import com.opencsv.CSVReader;
-import com.opencsv.ICSVWriter;
-import lombok.SneakyThrows;
-
-
 import com.mcmasterbaja.model.AnalyzerParams;
 import com.mcmasterbaja.model.AnalyzerType;
 import com.opencsv.CSVReader;
 import com.opencsv.ICSVWriter;
-import com.opencsv.exceptions.CsvValidationException;
 import jakarta.enterprise.context.Dependent;
 import jakarta.inject.Inject;
-import java.io.IOException;
+import lombok.SneakyThrows;
 import org.jboss.logging.Logger;
 
 @Dependent

diff --git a/backend/src/main/java/com/mcmasterbaja/analyzer/CubicAnalyzer.java b/backend/src/main/java/com/mcmasterbaja/analyzer/CubicAnalyzer.java
@@ -1,13 +1,7 @@
 package com.mcmasterbaja.analyzer;
 
-import java.io.IOException;
-
 import com.mcmasterbaja.annotations.OnAnalyzerException;
 import com.mcmasterbaja.exceptions.InvalidHeaderException;
-import com.opencsv.CSVReader;
-import com.opencsv.ICSVWriter;
-import com.opencsv.exceptions.CsvValidationException;
-
 import com.mcmasterbaja.model.AnalyzerParams;
 import com.mcmasterbaja.model.AnalyzerType;
 import com.opencsv.CSVReader;
@@ -87,7 +81,7 @@ public void cubicMultiply(
       double timestamp = Double.parseDouble(nextLine[xAxisIndex]);
       double data = Double.parseDouble(nextLine[yAxisIndex]);
       double newValue = cubicFunction(data);
-      writer.writeNext(new String[] { Double.toString(timestamp), Double.toString(newValue) });
+      writer.writeNext(new String[] {Double.toString(timestamp), Double.toString(newValue)});
     }
 
     reader.close();
@@ -97,4 +91,4 @@ public void cubicMultiply(
   private double cubicFunction(double x) {
     return this.a * Math.pow(x, 3) + this.b * Math.pow(x, 2) + this.c * x + this.d;
   }
-}
+}