PHPStan (+PHPUnit) corrections, pt 1 #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettw
added
php
garrettw
changed the title
|
Since we don't see anything in the workflow regarding these warnings. Would it be a good idea to introduce a PHPStan workflow/step as well? |
|
Yes, but I don’t think we’re ready for it yet. Even if it were marked as not required, it would make every test run fail with a red X until all ~2200 issues are fixed, which I don’t think is helpful. I would support adding it after I finish going through and fixing everything, though. |
melroy89
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1340
Decided to include PHPUnit deprecation fixes while I'm at it, since it was quick and easy.
This one should be pretty straightforward; there aren't many changes to actual code that could be impactful.
Fixes #1338