Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devcontainer improvements #1333

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Devcontainer improvements #1333

merged 2 commits into from
Dec 30, 2024

Conversation

garrettw
Copy link
Contributor

added missing env file, fixed vhost config

added missing env file, fixed vhost config
@garrettw garrettw added bug Something isn't working low priority does not impact production code DX Impacts developer experience labels Dec 30, 2024
@melroy89
Copy link
Member

Is it possible to create maybe some sort of symbolic link for this dot env file? To avoid duplicate info? And more importantly to avoid forgetting to update also this dot env file in the future.

@garrettw
Copy link
Contributor Author

garrettw commented Dec 30, 2024

The purpose of this file is not to get it into a correct path to be used — quite the opposite, in fact. This file is meant to be used exactly as is with the devcontainer. It contains all the correct settings for the various included services so that everything works out of the box (or at least it should). What happens when the container is created is that this file gets copied to /.env where the app can use it.

@melroy89
Copy link
Member

melroy89 commented Dec 30, 2024

Would have been nice to create a symlink from .env.devcontainer to: https://github.com/MbinOrg/mbin/blob/main/.env.example_docker. Which is what I was trying to say.

But I think the settings are too different ;(

@garrettw garrettw enabled auto-merge (squash) December 30, 2024 21:12
@garrettw garrettw merged commit 6dd1446 into main Dec 30, 2024
7 checks passed
@garrettw garrettw deleted the devcontainer branch December 30, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DX Impacts developer experience low priority does not impact production code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants