Get the integration tests up and running again #1300
+5,049
−5,554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentiGorlich
added
php
BentiGorlich
force-pushed
the
fix/tests
branch
2 times, most recently
from
4c32edd to
82db8d1
Compare
- The messenger transactional wrap is not working with the tests, as it conflicts with the DoctrineTestBundle - Fix some type problems (DateTime vs DateTimeImmutable, nulls and initialization errors) - `SearchManager::findActivityPubActorsByUsername` now converts `!user@domain` into `@user@domain` so searching for a magazine by `!mag@domain` works from the API as well - The `StatsContentRepository` had a sign error - add a new docker compose for the test dependencies, as well as oauth keys for the tests - remove the purge user test, as this is no longer an option - change the .env.test to fit the new dependencies
BentiGorlich
force-pushed
the
fix/tests
branch
from
82db8d1 to
18db1cc
Compare
melroy89
reviewed
Dec 17, 2024
BentiGorlich
force-pushed
the
fix/tests
branch
3 times, most recently
from
f18437b to
e4f5cea
Compare
BentiGorlich
force-pushed
the
fix/tests
branch
from
e4f5cea to
9768db4
Compare
|
Ok, so it is now working, but the tests take forever: 23 minutes. There is a library called paratest that utilizes parallel testing, however the transaction isolation is not working at the moment (I have no idea why) so we have random assert failures with it (just tested it) |
|
Ok, so just checked what actually happens. It does not commit anything to the DB, however cahing is screwing us a little bit and the static settings were a problem. I am working on it :D |
|
If you need more php extensions installed. Let me know right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchManager::findActivityPubActorsByUsernamenow converts!user@domaininto@user@domainso searching for a magazine by!mag@domainworks from the API as wellStatsContentRepositoryhad a sign error