Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for banned instances + improved logging #1254

Merged
merged 9 commits into from
Nov 27, 2024

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Nov 26, 2024

  • Check for banned instances on missing places
  • Improve logging
  • Extend comment & code docs (please, do this always if you finally understand the method, this will help other devs)

Fixes : 18th issue of #1175

@melroy89 melroy89 added the enhancement New feature or request label Nov 26, 2024
@melroy89 melroy89 added this to the v1.7.4 milestone Nov 26, 2024
@melroy89
Copy link
Member Author

OK it seems to work as expected now on my instance (kbin.melroy.org).

Copy link
Member

@BentiGorlich BentiGorlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one thing I commented on in the code definitely needs to be changed. Otherwise the changes look good to me, though I think it could be useful to prepend the origin class to the log statements like

The instance is banned, url: {url}

Maybe something like:

[ActivityPubManager::getEntityObject] The instance is banned, url: {url}

src/Service/ActivityPubManager.php Outdated Show resolved Hide resolved
@melroy89 melroy89 enabled auto-merge (squash) November 27, 2024 22:38
@melroy89 melroy89 merged commit 5535997 into main Nov 27, 2024
7 checks passed
@melroy89 melroy89 deleted the improve_is_banned_instances branch November 27, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants