-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for banned instances + improved logging #1254
Conversation
OK it seems to work as expected now on my instance (kbin.melroy.org). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one thing I commented on in the code definitely needs to be changed. Otherwise the changes look good to me, though I think it could be useful to prepend the origin class to the log statements like
The instance is banned, url: {url}
Maybe something like:
[ActivityPubManager::getEntityObject] The instance is banned, url: {url}
Fixes : 18th issue of #1175