Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump doctrine/orm from 2.20.0 to 3.3.0 #1224

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 16, 2024

Bumps doctrine/orm from 2.20.0 to 3.3.0.

Release notes

Sourced from doctrine/orm's releases.

3.3.0

Release Notes for 3.3.0

Feature release (minor)

3.3.0

  • Total issues resolved: 0
  • Total pull requests resolved: 12
  • Total contributors: 8

New Features

Improvements

Deprecations

Documentation

Static Analysis

3.2.3

Release Notes for 3.2.3

3.2.x bugfix release (patch)

3.2.3

  • Total issues resolved: 0
  • Total pull requests resolved: 2
  • Total contributors: 2

... (truncated)

Upgrade guide

Sourced from doctrine/orm's upgrade guide.

Upgrade to 3.3

Deprecate DatabaseDriver

The class Doctrine\ORM\Mapping\Driver\DatabaseDriver is deprecated without replacement.

Add Doctrine\ORM\Query\OutputWalker interface, deprecate Doctrine\ORM\Query\SqlWalker::getExecutor()

Output walkers should implement the new \Doctrine\ORM\Query\OutputWalker interface and create Doctrine\ORM\Query\Exec\SqlFinalizer instances instead of Doctrine\ORM\Query\Exec\AbstractSqlExecutors. The output walker must not base its workings on the query firstResult/maxResult values, so that the SqlFinalizer can be kept in the query cache and used regardless of the actual firstResult/maxResult values. Any operation dependent on firstResult/maxResult should take place within the SqlFinalizer::createExecutor() method. Details can be found at doctrine/orm#11188.

Upgrade to 3.2

Deprecate the NotSupported exception

The class Doctrine\ORM\Exception\NotSupported is deprecated without replacement.

Deprecate remaining Serializable implementation

Relying on SequenceGenerator implementing the Serializable is deprecated because that interface won't be implemented in ORM 4 anymore.

The following methods are deprecated:

  • SequenceGenerator::serialize()
  • SequenceGenerator::unserialize()

orm:schema-tool:update option --complete is deprecated

That option behaves as a no-op, and is deprecated. It will be removed in 4.0.

Deprecate properties $indexes and $uniqueConstraints of Doctrine\ORM\Mapping\Table

The properties $indexes and $uniqueConstraints have been deprecated since they had no effect at all. The preferred way of defining indices and unique constraints is by using the \Doctrine\ORM\Mapping\UniqueConstraint and \Doctrine\ORM\Mapping\Index attributes.

Upgrade to 3.1

Deprecate Doctrine\ORM\Mapping\ReflectionEnumProperty

This class is deprecated and will be removed in 4.0. Instead, use Doctrine\Persistence\Reflection\EnumReflectionProperty from doctrine/persistence.

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update PHP code labels Nov 16, 2024
@BentiGorlich
Copy link
Member

This is a HUGE version jump. The 3.0.0 release has A LOT of breaking changes: https://github.com/doctrine/orm/blob/3.0.x/UPGRADE.md

@melroy89 melroy89 added this to the v1.7.4 milestone Nov 24, 2024
@melroy89
Copy link
Member

melroy89 commented Nov 25, 2024

This is a HUGE version jump. The 3.0.0 release has A LOT of breaking changes: https://github.com/doctrine/orm/blob/3.0.x/UPGRADE.md

Thanks for the note, this is indeed a major package upgrade to the latest doctrine v3. And we should not just merge this PR :P

We will need to test this very thoroughly and this upgrade guide should help us as well.

@dependabot dependabot bot force-pushed the dependabot/composer/doctrine/orm-3.3.0 branch 10 times, most recently from 3e74448 to 002be44 Compare November 30, 2024 23:54
@dependabot dependabot bot force-pushed the dependabot/composer/doctrine/orm-3.3.0 branch 5 times, most recently from 4bfb2a2 to 538a3b7 Compare December 10, 2024 14:28
@melroy89 melroy89 added the hold label Dec 10, 2024
@melroy89 melroy89 modified the milestones: v1.7.4, v1.8.1 Dec 13, 2024
@dependabot dependabot bot force-pushed the dependabot/composer/doctrine/orm-3.3.0 branch 7 times, most recently from c84bb15 to 7f68103 Compare December 15, 2024 17:06
Bumps [doctrine/orm](https://github.com/doctrine/orm) from 2.20.0 to 3.3.0.
- [Release notes](https://github.com/doctrine/orm/releases)
- [Upgrade guide](https://github.com/doctrine/orm/blob/3.3.x/UPGRADE.md)
- [Commits](doctrine/orm@2.20.0...3.3.0)

---
updated-dependencies:
- dependency-name: doctrine/orm
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/composer/doctrine/orm-3.3.0 branch from 7f68103 to 4829926 Compare December 15, 2024 17:09
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 21, 2024

Superseded by #1309.

@dependabot dependabot bot closed this Dec 21, 2024
@dependabot dependabot bot deleted the dependabot/composer/doctrine/orm-3.3.0 branch December 21, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file hold php Pull requests that update PHP code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants