Add durations to search results #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great idea, actually. And there is much more than just the duration that could be returned from that additional call. However, i'm not sure if it belongs in here or not. If yes then definitely only when a separate option is set. Or maybe in an additional method. I would love to hear some opinions on this. |
Open
|
This PR looks great! Currently looking for this functionality Agree with the separate option to be set for it. If this thread is still alive, I could fork ottomated's version to raise another PR to add the separate option for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the youtube API to get the duration of each video returned from the search results. Could possibly be added as a seperate option due to additional request overhead.