Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable configuration of storage types via CLI #9

Closed
HerrHorizontal opened this issue Oct 20, 2020 · 3 comments
Closed

Enable configuration of storage types via CLI #9

HerrHorizontal opened this issue Oct 20, 2020 · 3 comments
Assignees
@HerrHorizontal
Labels
enhancement New feature or request

Comments

@HerrHorizontal
Copy link
Contributor

HerrHorizontal commented Oct 20, 2020 •
edited
Loading

At the current state, the cli simulate.py allows only one storage_type to be chosen. Also it isn't possible to define more than one storage element.
@HerrHorizontal HerrHorizontal added enhancement New feature or request invalid This doesn't seem right refactoring Restructuring for better intelligibility labels Oct 20, 2020
This was referenced Oct 20, 2020
Closed
Closed
@eileen-kuehn eileen-kuehn removed the invalid This doesn't seem right label Oct 29, 2020
@HerrHorizontal HerrHorizontal self-assigned this Jun 15, 2021
@HerrHorizontal HerrHorizontal linked a pull request Jun 15, 2021 that will close this issue
extension/cli #24
Merged
@HerrHorizontal
Copy link
Contributor Author

HerrHorizontal commented Jun 15, 2021 •
edited
Loading

This was attempted by #24, but not fully pulled off. While making multiple storage elements configurable via CLI, the type is still hard-coded. I suggest adding a tuple-parameter to storage_files in https://github.com/MatterMiners/lapis.caching/blob/add/initial-code/lapis/cli/simulate.py#L80-L91, which also includes the storage_type.

@HerrHorizontal HerrHorizontal removed a link to a pull request Jun 15, 2021
extension/cli #24
Merged
@eileen-kuehn eileen-kuehn changed the title [Simulation] Enable configuration of storage types Enable configuration of storage types Jun 21, 2021
@eileen-kuehn
Copy link
Member

Could you please clarify the description of this issue? What do you mean with choosing of one storage element? What are the relevant points of issues #6 and #8?
And to which choice are you referring to in the last sentence?

@HerrHorizontal
Copy link
Contributor Author

Could you please clarify the description of this issue? What do you mean with choosing of one storage element? What are the relevant points of issues #6 and #8?
And to which choice are you referring to in the last sentence?

see above

@eileen-kuehn eileen-kuehn changed the title Enable configuration of storage types Enable configuration of storage types via CLI Jun 21, 2021
@eileen-kuehn eileen-kuehn removed the refactoring Restructuring for better intelligibility label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HerrHorizontal HerrHorizontal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maxfischer2781 @eileen-kuehn @HerrHorizontal