Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule to bypass TLD country domains #546

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Rule to bypass TLD country domains #546

wants to merge 1 commit into from

Conversation

turikhay
Copy link
Contributor

@turikhay turikhay commented Feb 7, 2024

geoip:ru and geosite:ru may not explicitly cover all *.ru domains.
And I'm not sure if this is the right way to add these. Please tell me what you think.

@omgiafs
Copy link

omgiafs commented Mar 2, 2024 •
edited
Loading

geoip:ru and geosite:ru may not explicitly cover all *.ru domains.

Hi! Firstly, this fields are in deprecated state: link
Secondly, these databases do not contain lists of russian sites, so it's pointless to use them.
Thirdly, it's much better to use domain:ru as described on nb4a site and accordingly with your commit. Thus we blocking all *.ru domains with no exceptions.
And fourthly: you forget to add "ru:Russia" in "fuckedCountry" mutable list 😢

@nuckle nuckle mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turikhay @omgiafs