This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
Allow patches to be updated #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
|
This will overwrite random files belonging to other wikis, because the deduplication uses hardlinks. |
|
Is there a way to turn off the duplication after it's been done? |
|
You could just copy the whole directory. There might be another way, but
this will definitely work.
|
Done. Copying the files is a fairly quick operation. |
edg2s
force-pushed
the
update
branch
2 times, most recently
from
eb850d3 to
d2422d3
Compare
edg2s
force-pushed
the
update
branch
2 times, most recently
from
b8585b1 to
914b903
Compare
edg2s
commented
Mar 2, 2022
new/unlink.sh
Outdated
|
|
||
| # Copy all files so they are no longer hard-link duplicates of other | ||
| # files on the system (reverse of deduplicate.js) | ||
| cp -r $PATCHDEMO/wikis/$NAME/w $PATCHDEMO/wikis/$NAME/w-cloned |
There was a problem hiding this comment.
Offline code review from @Tchanders suggested this could fail if rdfind is running while we are updating the new wiki.
My initial though would be to leave the wiki in w-cloned while updating, and modify our rdfind cron job to exclude folders called w-cloned.
There was a problem hiding this comment.
Fixed (used w-updating)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54