Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track changes in mathics-core #30

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Track changes in mathics-core #30

merged 1 commit into from
Aug 3, 2024

Conversation

rocky
Copy link
Member

@rocky rocky commented Aug 3, 2024

setup.py: We need at least Python 3.8
.editorconfig: remove duplicate config line
__init__.py: add just in case Adding would mess up other Mathics3 modules.
test_summary_text.py: import location has moved

@rocky rocky requested a review from mmatera August 3, 2024 10:14
@rocky rocky force-pushed the track-doc-api-changes branch from 174fcea to dfe1246 Compare August 3, 2024 10:15
@rocky
Copy link
Member Author

rocky commented Aug 3, 2024

This is the smallest set of changes to get "make test" working and adjust this to current Python standards.

I considered converting to using a pyproject.toml file, but that requires more work.

setup.py: We need at least Python 3.8
.editorconfig: remove duplicate config line
__init__.py: add just in case
test_summary_text.py: import location has moved
@rocky rocky force-pushed the track-doc-api-changes branch from dfe1246 to bd6a2d4 Compare August 3, 2024 12:37
@rocky rocky marked this pull request as draft August 3, 2024 12:55
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Later we can fix the issue with the 3.10 tests.

@rocky rocky marked this pull request as ready for review August 3, 2024 20:42
@rocky rocky merged commit 8f1fe3c into master Aug 3, 2024
2 of 3 checks passed
@rocky rocky deleted the track-doc-api-changes branch August 3, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants