Precedence tests #99
Precedence tests #99
Conversation
|
Whether the tests could be implemented at a lower level, just looking into the tables, I want to include later some tests checking how certain expressions are parsed and formatted when the precedence values are taken into account, so I need Mathics-core for that. |
|
For some reason, from this side the precedence values for |
Are you working from a cloned Github repository instead of the last released code? This is probably something that can be easily debugged. |
|
No, the problem was that the github action workflow uses the operator-info-from-JSON branch of Mathics-core. Once I updated the branch, the test passed. |
test/test_mathics_precedence.py
Outdated
| "LeftTee", | ||
| "Perpendicular", # 190 | ||
| "RightTee", # 190 | ||
| # In WMA, `RoundImplies` has a |
There was a problem hiding this comment.
We probably need to adjust the precedence values in the tables for UpTee and RoundImplies
test/test_mathics_precedence.py
Outdated
| "TildeEqual", | ||
| "TildeFullEqual", | ||
| "TildeTilde", | ||
| # In Mathics, the precedence of these operators is quite low. |
There was a problem hiding this comment.
Is there a reason to choose these lower values for the precedence of these operators?
There was a problem hiding this comment.
Is there a reason to choose these lower values for the precedence of these operators?
See #99 (comment)
test/test_mathics_precedence.py
Outdated
| "CircleDot", | ||
| "SmallCircle", | ||
| "Square", # 540 | ||
| "Del", # In WMA, has the same precedence as DifferentialD and CapitalDifferentialD |
There was a problem hiding this comment.
I do not see the need of using a different value of precedence for these operators.
There was a problem hiding this comment.
Ok. Put in a isolated PR for this change along with changing the test to work from master. If the tests succeed, we can merge that in and delete operators_from_JSON branch in mathics-core.
There was a problem hiding this comment.
Yep, this is just about the tests. Here I just wanted to leave the comments.
test/test_mathics_precedence.py
Outdated
| "PlusMinus", | ||
| "Plus", | ||
| "Subtract", # 310 | ||
| # "Integrete", # In Mathics, this has the default precedence. In WMA, 325 |
There was a problem hiding this comment.
At some point, we need to look over again the way how the information for Integral and Integrate operators are stored in the tables..
Ah, that was a step I forgot to do after the branch got merged. |
|
The tests are already merged |
This includes the tests proposed in Mathics3/mathics-core#1192 where it should belong.