-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String tokenization fix #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recognize CTRL-characters \n, \t, \r, etc feed.py: lint and fix types Split out string token test from other test_tokeniser.py which is rather large.
rocky
force-pushed
the
string-tokenization-fix
branch
5 times, most recently
from
December 11, 2024 19:12
236b904
to
60051d8
Compare
rocky
force-pushed
the
string-tokenization-fix
branch
from
December 11, 2024 19:14
60051d8
to
ba02e6f
Compare
mmatera
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rocky
added a commit
that referenced
this pull request
Dec 12, 2024
rocky
added a commit
that referenced
this pull request
Dec 13, 2024
feed.py: lint and fix types test/test_string_tokens.py: Split out string token test from other test_tokeniser.py which is getting large. Add more string token tests.
Merged
rocky
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle backslash better...
Recognize special escape characters \n, \t, \r, etc., but disallow other characters.
feed.py: lint and fix types
test/test_string_tokens.py: Split out string token test from other test_tokeniser.py which is getting large. Add more string token tests.