Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String tokenization fix #108

Merged
merged 3 commits into from
Dec 12, 2024
Merged

String tokenization fix #108

merged 3 commits into from
Dec 12, 2024

Conversation

rocky
Copy link
Member

@rocky rocky commented Dec 11, 2024

Handle backslash better...

Recognize special escape characters \n, \t, \r, etc., but disallow other characters.

feed.py: lint and fix types

test/test_string_tokens.py: Split out string token test from other test_tokeniser.py which is getting large. Add more string token tests.

Recognize CTRL-characters \n, \t, \r, etc
feed.py: lint and fix types

Split out string token test from other test_tokeniser.py which is
rather large.
@rocky rocky requested a review from mmatera December 11, 2024 18:17
@rocky rocky marked this pull request as draft December 11, 2024 18:17
@rocky rocky force-pushed the string-tokenization-fix branch 5 times, most recently from 236b904 to 60051d8 Compare December 11, 2024 19:12
@rocky rocky force-pushed the string-tokenization-fix branch from 60051d8 to ba02e6f Compare December 11, 2024 19:14
@rocky rocky marked this pull request as ready for review December 11, 2024 19:16
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky merged commit e26f5bc into master Dec 12, 2024
12 checks passed
@rocky rocky deleted the string-tokenization-fix branch December 12, 2024 01:38
rocky added a commit that referenced this pull request Dec 12, 2024
rocky added a commit that referenced this pull request Dec 12, 2024
rocky added a commit that referenced this pull request Dec 13, 2024
feed.py: lint and fix types

test/test_string_tokens.py: Split out string token test from other test_tokeniser.py which is getting large. Add more string token tests.
@rocky rocky mentioned this pull request Dec 13, 2024
rocky added a commit that referenced this pull request Dec 13, 2024
feed.py: lint and fix types

test/test_string_tokens.py: Split out string token test from other test_tokeniser.py which is getting large. Add more string token tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants