Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_private seems to have disappeared. #213

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

rocky
Copy link
Member

@rocky rocky commented Nov 6, 2024

I am seeing when trying to get the documentation for TraceBuiltins

...
  File "/tmp/Mathics3/mathics-django/mathics_django/doc/django_doc.py", line 183, in html
    items = [item for item in self.items if not item.is_private()]
                                                ^^^^^^^^^^^^^^^
AttributeError: 'DjangoDocText' object has no attribute 'is_private'

is_private no longer is part of a DocumentationEntry.

See https://github.com/Mathics3/mathics-core/blob/master/mathics/doc/doc_entries.py#L431

@rocky rocky requested a review from mmatera November 6, 2024 22:03
@mmatera
Copy link
Contributor

mmatera commented Nov 7, 2024

@rocky, in the current state, private is an attribute of individual DocTest objects, not of DocTests (bunches of tests) or DocTest. So I think it is safe to make this change.

Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatera
Copy link
Contributor

mmatera commented Nov 7, 2024

BTW, I checked it out, and using this branch, private tests (like the #> Clear in /reference-of-built-in-symbols/procedural-programming/Catch ) are not shown in the online documentation.

@rocky
Copy link
Member Author

rocky commented Nov 8, 2024

BTW, I checked it out, and using this branch, private tests (like the #> Clear in /reference-of-built-in-symbols/procedural-programming/Catch ) are not shown in the online documentation.

Thanks!

@rocky rocky merged commit 3fc4f01 into master Nov 8, 2024
9 checks passed
@rocky rocky deleted the is_private-disappears branch November 8, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants