compatibility with mathics-core PR 986 #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2024
mmatera
force-pushed
the
update_doc_PR986
branch
from
738123e to
48fc421
Compare
rocky
added a commit
to Mathics3/mathics-core
that referenced
this pull request
Feb 7, 2024
This PR continues #990 by moving the inner loop that loads chapters in `MathicsMainDocumentation.doc_part` to a new method `MathicsMainDocumentation.doc_chapter`. With this change, the "on the fly" loading of documentation for Pymathics modules loaded in a Django session now is possible (and is implemented in Mathics3/mathics-django#201) --------- Co-authored-by: R. Bernstein <[email protected]>
rocky
reviewed
Feb 9, 2024
| # print("XXX refresh pymathics doc") | ||
| global documentation | ||
| documentation = MathicsDjangoDocumentation() | ||
| print("XXX refresh pymathics doc", pymathics_modules) |
There was a problem hiding this comment.
Sorry about this. I forgot to comment it out again.
rocky
reviewed
Feb 9, 2024
| "mathics3-modules", None | ||
| ) | ||
| # If this is the first loaded module, we need to create the Part | ||
| if mathics3_module_part is None: |
There was a problem hiding this comment.
This doesn't have to be in a for loop.
rocky
reviewed
Feb 9, 2024
| ) | ||
| # If this is the first loaded module, we need to create the Part | ||
| if mathics3_module_part is None: | ||
| mathics3_module_part = self.doc_part( |
There was a problem hiding this comment.
self is not right, it is documentation here. Must be a cut and paste error.
There was a problem hiding this comment.
I have incorporated the good parts of this PR into #202
There was a problem hiding this comment.
Indeed, it was a cut-and-paste error.
|
Superceded by #202 (although there was some good code here.). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is needed to keep compatibility with Mathics3/mathics-core#986