-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitization of job name and tests for PBS #53
Conversation
A few notes:
|
Few updates following the merge of #52. Concerning the query based on users, it seems that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost all good to me. I think there is one small bug in the data_objects (see comment). Then a few comments here and there. Otherwise great work!
Co-authored-by: David Waroquiers <[email protected]>
To address this issue Matgenix/jobflow-remote#112 introduce a sanitization for the name of the jobs for PBS and SGE. The choice of the characters to replace is based on explicit tests in the PBS and SGE containers from jobflow-remote's integration tests.
Also adding test for PBS as some regression was introduced when adding SGE. It would be better to add integration tests similar to jobflow-remote to improve the reliability.