Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OQMD's info to providers.json #52

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Adding OQMD's info to providers.json #52

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afc0147
Added OQMD's info in providers
tachyontraveler Dec 18, 2020
fd42b28
adding index meta-db for OQMD
tachyontraveler Dec 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/links/v1/providers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,10 @@
"type": "links",
"id": "oqmd",
"attributes": {
"name": "open quantum materials database",
"description": "",
"base_url": null,
"homepage": null,
"name": "The Open Quantum Materials Database",
"description": "The OQMD is a database of DFT calculated thermodynamic and structural properties of materials",
"base_url": "http://oqmd.org/optimade",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be the only change required in the providers file, you would then need to add an oqmd/ folder that follows the same structure as e.g. https://github.com/Materials-Consortia/providers/tree/master/src/index-metadbs/mp/v1

Suggested change
"base_url": "http://oqmd.org/optimade",
"base_url": "http://providers.optimade.org/index-metadbs/oqmd",

Copy link
Member

@ml-evs ml-evs Dec 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR still hasn't made it in, but the instructions are all there if you wanted to self-host #18 or here https://github.com/Materials-Consortia/providers/tree/master/src/index-metadbs if you wanted to use this repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR still hasn't made it in, but the instructions are all there if you wanted to self-host #18 or here https://github.com/Materials-Consortia/providers/tree/master/src/index-metadbs if you wanted to use this repo

I have just merged this now. So you can read the instructions directly in the repository README on the landing page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ml-evs and @CasperWA ! I've added a new directory in index-metadb and changed the API response from HTML to JSON.

"homepage": "http://oqmd.org",
"link_type": "external"
}
},
Expand Down