Update MP provider #23
Conversation
|
@shyamd Could you update this either with the new "hosted" index meta-database in this repository or with a link to the un-versioned base URL of your own managed index meta-database? :) |
# Conflicts: # src/links/v1/providers.json
|
@shyamd The test failures are not necessarily due to your setup, but rather our new semver validation in the optimade-python-tools. It doesn't like the currently available index meta-databases for some reason (I believe it's the prefixed |
There was a problem hiding this comment.
The changes for name and description are simply suggestions. The latter since you essentially have the title/name repeated in the description.
The standard api_version value is wrong, I have put in a PR to update it, see #40.
Also, did you know your optimade server returns a 502?
| "attributes" : { | ||
| "available_api_versions" : [ | ||
| { | ||
| "version" : "1.0.0", |
There was a problem hiding this comment.
| "version" : "1.0.0", | |
| "version" : "1.0.0-rc.2", |
| "info", | ||
| "links" | ||
| ], | ||
| "api_version" : "v1.0.0" |
There was a problem hiding this comment.
| "api_version" : "v1.0.0" | |
| "api_version" : "1.0.0-rc.2" |
| { | ||
| "data" : [ | ||
| { | ||
| "id" : "exmpl", |
There was a problem hiding this comment.
| "id" : "exmpl", | |
| "id" : "mp", |
| "type" : "links", | ||
| "attributes" : { | ||
| "name": "Materials Project", | ||
| "description": "The Materials Project: A database of computed materials properties for the discovery and design of novel materials.", |
There was a problem hiding this comment.
| "description": "The Materials Project: A database of computed materials properties for the discovery and design of novel materials.", | |
| "description": "A database of computed materials properties for the discovery and design of novel materials.", |
| "id" : "exmpl", | ||
| "type" : "links", | ||
| "attributes" : { | ||
| "name": "Materials Project", |
There was a problem hiding this comment.
| "name": "Materials Project", | |
| "name": "The Materials Project", |
| "description": "The Materials Project: A database of computed materials properties for the discovery and design of novel materials.", | ||
| "base_url": "https://optimade.materialsproject.org", | ||
| "homepage": "https://materialsproject.org", | ||
| "link_type": "child" |
There was a problem hiding this comment.
| "link_type": "child" | |
| "link_type": "external" |
| "base_url": null, | ||
| "homepage": null, | ||
| "name": "Materials Project", | ||
| "description": "The Materials Project: A database of computed materials properties for the discovery and design of novel materials.", |
There was a problem hiding this comment.
| "description": "The Materials Project: A database of computed materials properties for the discovery and design of novel materials.", | |
| "description": "A database of computed materials properties for the discovery and design of novel materials.", |
| "description": "", | ||
| "base_url": null, | ||
| "homepage": null, | ||
| "name": "Materials Project", |
There was a problem hiding this comment.
| "name": "Materials Project", | |
| "name": "The Materials Project", |
|
I'm going to open a new PR since this is pretty stale. |
Updates the Materials Project provider