adapter/sources: Support custom timelines on source tables to handle CdCv2 envelope type correctly #30013
+150
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The above bug demonstrated hung queries whenever using a
CREATE TABLE .. FROM SOURCE .. ENVELOPE MATERIALIZE
statement, sinceENVELOPE MATERIALIZE
(also known asEnvelope::CdcV2
) uses a non-default timeline by default.This PR introduces the ability to set a custom timeline on
CREATE TABLE .. FROM SOURCE
and to correct the default timeline when usingENVELOPE MATERIALIZE
, matching the existing timeline handling semantics ofCREATE SOURCE
statements.The tests for this are in @nrainer-materialize 's PR #29801 and I tested this change on his branch locally to verify the fix.
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.