Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter: Add OfflineReason::Initializing for cluster replicas #30012

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ParkMyCar
Copy link
Member

This PR adds an new offline reason for cluster replicas of "initializing". When the DDL that creates a new cluster replica completes, that replica starts with a status of offline and a reason: null, once Kubernetes creates the replica it gets updates to a status of online.

This change should make that initializing period more obvious.

Motivation

We recently saw an issue where the mz_internal.mz_cluster_replica_statuses history was incorrect, and I'm hoping this PR should help us debug the issue a bit further if we see it again. (Slack)

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar requested review from benesch and a team as code owners October 15, 2024 21:16
Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants