Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/sources: Allow user-specified column names in CREATE TABLE FROM SOURCE statements #30008

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rjobanp
Copy link
Contributor

@rjobanp rjobanp commented Oct 15, 2024

Motivation

The issue above highlighted that the new CREATE TABLE .. FROM SOURCE statements did not allow the specification of column-names that we currently allow in CREATE SOURCE statements for some source types (Kafka sources and single-output load-generator sources).

This PR refactors our SQL parsing and purification/planning logic to accommodate this behavior.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@rjobanp rjobanp marked this pull request as ready for review October 15, 2024 17:12
@rjobanp rjobanp requested a review from a team as a code owner October 15, 2024 17:12
@rjobanp rjobanp requested a review from jkosh44 October 15, 2024 17:12
Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants