Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testdrive: get rid of failed writing row to mz_aws_connections table #29992

Conversation

nrainer-materialize
Copy link
Contributor

@nrainer-materialize nrainer-materialize commented Oct 15, 2024

This addresses https://github.com/MaterializeInc/database-issues/issues/8653.

Get rid of

[2m2024-10-11T06:09:53.863297Z[0m [31mERROR[0m [2mmz_adapter::catalog::builtin_table_updates[0m[2m:[0m failed writing row to mz_aws_connections table [3mid[0m[2m=[0ms759 [3me[0m[2m=[0minternal error: no AWS external ID prefix configured

@nrainer-materialize
Copy link
Contributor Author

nrainer-materialize commented Oct 15, 2024

@benesch, should this work? (Spoiler: It does not yet.)

@benesch
Copy link
Member

benesch commented Oct 15, 2024

Hm, I didn't realize we already set the external ID prefix in the mzcompose test. Interesting! Can you link me to where you're seeing the error logs in Buildkite? Something I don't understand is going wrong here.

@nrainer-materialize
Copy link
Contributor Author

Can you link me to where you're seeing the error logs in Buildkite? Something I don't understand is going wrong here.

Sure! An example is in "Testdrive 1", line 345.

@benesch benesch marked this pull request as ready for review October 15, 2024 20:15
@benesch benesch requested a review from a team as a code owner October 15, 2024 20:15
@benesch
Copy link
Member

benesch commented Oct 15, 2024

Ahh! It's testdrive itself that's emitting the error. Not the materialized service (i.e., not in services.log). I pushed up a commit that should fix this.

@nrainer-materialize
Copy link
Contributor Author

nrainer-materialize commented Oct 16, 2024

Thank you, @benesch!

I fixed the compilation issue but I fear that the log entry still occurs and we get a different error message:

2024-10-16T06:29:57.364989Z ERROR mz_adapter::catalog::builtin_table_updates:
failed writing row to mz_aws_connections table id=s759 e=internal error: no AWS connection role configured

when running bin/mzcompose --find testdrive down && bin/mzcompose --find testdrive run default --default-timeout 5s mz-sources.td

I will try to fix it.

@nrainer-materialize nrainer-materialize changed the title tests: specify AWS external ID prefix testdrive: get rid of failed writing row to mz_aws_connections table Oct 16, 2024
…on context

To suppress errors about failing to write builtin table updates for AWS
connections.

Fix MaterializeInc/database-issues#8653.
@nrainer-materialize nrainer-materialize merged commit 71533c1 into MaterializeInc:main Oct 16, 2024
80 checks passed
@nrainer-materialize nrainer-materialize deleted the tests/specify-aws-prefix branch October 16, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants