parallel-benchmark: Store data in SQLite for long runs #29956
Merged
+223
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
force-pushed
the
pr-sqlite-store
branch
3 times, most recently
from
6914a16
to
618a779
Compare
def-
changed the title
def-
force-pushed
the
pr-sqlite-store
branch
4 times, most recently
from
3f9fccf
to
d4ee745
Compare
Seems not to cause a performance difference, but lacks some features currently
nrainer-materialize
approved these changes
Oct 16, 2024
|
The QA Canary job runs parallel-benchmark for 24 hours, it would require a beefy machine to keep all the results in memory, so I'd rather have a small machine and store the results on disk. |
Makes sense! I was not aware that we are collecting that much data. |
| (m.scenario, action), | ||
| ) | ||
| self.queries, self.qps, self.max, self.min, self.avg = cursor.fetchone() | ||
| # TODO: Rest |
There was a problem hiding this comment.
There is an open TODO. Do you plan to address this within this PR?
Note that I cancelled auto-merge. Feel free to proceed, though.
There was a problem hiding this comment.
Nope, I left that for future me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems not to cause a performance difference, but lacks some features currently
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.