Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare x5c leaf cert aaguid and attestation aaguid #609

Merged
merged 4 commits into from
Sep 22, 2024

Conversation

MasterKale
Copy link
Owner

@MasterKale MasterKale commented Sep 22, 2024

This PR addresses some old TODO's related to making sure that the AAGUID present in an attestation statement's leaf cert's extensions, when present, matches the AAGUID in the attestation statement. "tpm" and "packed" attestations will become more stringent in this regard.

@MasterKale MasterKale added package:server @simplewebauthn/server enhancement New feature or request and removed enhancement New feature or request labels Sep 22, 2024
@MasterKale MasterKale added this to the v10.1.0 milestone Sep 22, 2024
@MasterKale MasterKale merged commit 328b7a3 into master Sep 22, 2024
1 check passed
@MasterKale MasterKale deleted the validate-x5c-aaguid-and-attestation-aaguid branch September 22, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:server @simplewebauthn/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant