Another attempt at submitting BfG spectra #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to update the dev to the current version
|
Kevin you are a legend, thanks for persisting with the submission. Have to let @meier-rene do his magic first, but UniLu are on standby to update PubChem etc integration as soon as we have the updated release! |
|
:) Thanks Emma! |
meier-rene
pushed a commit
that referenced
this pull request
Nov 17, 2023
…blenz, Germany as given in #249
|
Thank you! Your contribution is now merged into our development branch. Only thing I had to do was some minor cleanup of project files. Finally I squashed all commits into one single commit. Your effort is very much appreciated. The spectra will be released with the next official release. I will now prepare a new release of the software, because we included the new license. When the software is released I can create the new data release. You can expect it within the next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validator found a few more errors, which I corrected. There is still an uncertainty with MSBNK-BAFG-CSL231109456 (see issue: 248. But since it is just one file, I just changed it manually to the "l" variant.