Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for ET6448M pmon2.0 #53

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lkunjumon
Copy link

Signed-off-by: lkunjumon [email protected]

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@lkunjumon
Copy link
Author

@antony-rheneus @radha-danda please review pmon2.0 for et6448m

@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2021

This pull request introduces 13 alerts when merging 7727cfb into 64aa719 - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation
  • 4 for 'import *' may pollute namespace
  • 1 for Module imports itself
  • 1 for Wrong name for an argument in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Jun 29, 2021

This pull request introduces 14 alerts when merging 77393aa into 64aa719 - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation
  • 4 for 'import *' may pollute namespace
  • 2 for Wrong name for an argument in a class instantiation
  • 1 for Module imports itself

@lgtm-com
Copy link

lgtm-com bot commented Jun 29, 2021

This pull request introduces 14 alerts when merging 50c872a into 64aa719 - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation
  • 4 for 'import *' may pollute namespace
  • 2 for Wrong name for an argument in a class instantiation
  • 1 for Module imports itself

dev: '00'
fn: '0'
id: c804
name: 'Ethernet controller: Marvell Technology Group Ltd. Device c804'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think w shoudl add only c804 ac3x chips, and not all are requireed

et6448m/service/et6448m-init.service etc/systemd/system
et6448m/sonic_platform-1.0-py3-none-any.whl usr/share/sonic/device/armhf-marvell_et6448m_52x-r0
entropy.py etc/
inband_mgmt.sh etc/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this script packed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants