Add Time To Opponent #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acieroid
reviewed
Oct 18, 2021
src/app/components/normal-component/count-down/count-down.component.html
Outdated
Show resolved
Hide resolved
acieroid
reviewed
Oct 18, 2021
src/app/components/wrapper-components/online-game-wrapper/online-game-wrapper.component.ts
Outdated
Show resolved
Hide resolved
acieroid
reviewed
Oct 18, 2021
src/app/components/wrapper-components/online-game-wrapper/online-game-wrapper.component.ts
Outdated
Show resolved
Hide resolved
acieroid
reviewed
Oct 21, 2021
src/app/components/wrapper-components/online-game-wrapper/online-game-wrapper.component.ts
Show resolved
Hide resolved
acieroid
reviewed
Oct 21, 2021
src/app/components/wrapper-components/online-game-wrapper/online-game-wrapper.component.ts
Show resolved
Hide resolved
acieroid
reviewed
Oct 21, 2021
| turn: 16, | ||
| scorePlayerZero: null, | ||
| scorePlayerOne: null, | ||
| // remainingTimes ?? |
acieroid
reviewed
Oct 21, 2021
| @@ -1004,6 +1072,11 @@ describe('OnlineGameWrapperComponent of Quarto:', () => { | |||
| expect(wrapper.chronoOneGlobal.stop).toHaveBeenCalled(); | |||
| expect(wrapper.notifyTimeoutVictory).toHaveBeenCalled(); | |||
| })); | |||
| it('when resigning, lastMoveTime must be upToDate then remainingMs'); | |||
acieroid
reviewed
Oct 21, 2021
| @@ -1004,6 +1072,11 @@ describe('OnlineGameWrapperComponent of Quarto:', () => { | |||
| expect(wrapper.chronoOneGlobal.stop).toHaveBeenCalled(); | |||
| expect(wrapper.notifyTimeoutVictory).toHaveBeenCalled(); | |||
| })); | |||
| it('when resigning, lastMoveTime must be upToDate then remainingMs'); | |||
|
|
|||
| it('when winning move is done, remainingMs at last turn of opponent must be'); | |||
acieroid
reviewed
Oct 21, 2021
| it('when resigning, lastMoveTime must be upToDate then remainingMs'); | ||
| it('when winning move is done, remainingMs at last turn of opponent must be'); | ||
| }); | ||
| describe('AddTime functionnalities', () => { |
There was a problem hiding this comment.
feature? :D Ou simplement describe('AddTime') est assez clair
acieroid
reviewed
Oct 21, 2021
| }); | ||
| describe('AddTime functionnalities', () => { | ||
| it('should allow to add local time to opponent', fakeAsync(async() => { | ||
| // Given an onlineGameComponent |
There was a problem hiding this comment.
chipotage: OnlineGameComponent (use the right capitalization for class names)
acieroid
reviewed
Oct 21, 2021
| spyOn(partDAO, 'update').and.callThrough(); | ||
| tick(1); | ||
|
|
||
| // when local countDownComponent emit addTime |
acieroid
reviewed
Oct 21, 2021
| spyOn(partDAO, 'update').and.callThrough(); | ||
| tick(1); | ||
|
|
||
| // when local countDownComponent emit addTime |
acieroid
reviewed
Oct 21, 2021
| expect(wrapper.chronoZeroGlobal.remainingMs).toBe((30 * 60 * 1000) + (5 * 60 * 1000)); | ||
| tick(wrapper.joiner.maximalMoveDuration * 1000); | ||
| })); | ||
| it('should postponed the timeout of chrono and not only change displayed time', fakeAsync(async() => { |
acieroid
reviewed
Oct 21, 2021
| @@ -1370,6 +1560,37 @@ describe('OnlineGameWrapperComponent of Quarto:', () => { | |||
| expect(wrapper.getUpdateType(update)).toBe(UpdateType.REQUEST); | |||
| tick(wrapper.joiner.maximalMoveDuration * 1000 + 1); | |||
| })); | |||
| it('Request.LocalTimeAdded + one remainingMs modified = UpdateType.REQUEST', fakeAsync(async() => { | |||
| await prepareStartedGameFor({ pseudo: 'creator', verified: true }); | |||
| wrapper.currentPart = new Part({ | |||
There was a problem hiding this comment.
y'a pas moyen d'avoir les champs non important séparés des champs important ici pour rendre ça plus clair ?
acieroid
reviewed
Oct 21, 2021
Comment on lines
+78
to
+79
| // if the distribution would capture all seeds | ||
| // the move is legal but the capture is forbidden and cancelled |
There was a problem hiding this comment.
est-ce qu'on part sur cette convention pour du multiligne intra-fonction au final ? (si t'as changé le /* ... */ j'imagine que c'est que c'était perturbant !)
acieroid
reviewed
Oct 21, 2021
| // when asking list moves | ||
| const moves: AwaleMove[] = minimax.getListMoves(node); | ||
|
|
||
| // then length should be one and move be the only legal |
There was a problem hiding this comment.
the length should be one => there should be only one move ?
There was a problem hiding this comment.
ou simplement: the only move should be the only legal move
acieroid
reviewed
Oct 21, 2021
| @@ -61,6 +61,30 @@ describe('AwaleRules', () => { | |||
| const node: AwaleNode = new MGPNode(null, move, resultingState); | |||
| expectToBeVictoryFor(rules, node, Player.ONE, minimaxes); | |||
| }); | |||
| it('should not do mansoon when possible distribution', () => { | |||
acieroid
reviewed
Oct 21, 2021
| const status: AwaleLegalityStatus = rules.isLegal(move, state); | ||
| const resultingState: AwaleState = rules.applyLegalMove(move, state, status); | ||
|
|
||
| // then, since other player can actually distribute, he do not mansoon all his pieces |
acieroid
reviewed
Oct 21, 2021
| @@ -76,6 +100,30 @@ describe('AwaleRules', () => { | |||
| // then the move is illegal | |||
| expect(status.legal.reason).toBe(AwaleFailure.SHOULD_DISTRIBUTE()); | |||
| }); | |||
| it('should allow mansoon on one last capture', () => { | |||
acieroid
reviewed
Oct 21, 2021
Comment on lines
47
to
51
| if (state.pieceInHand !== QuartoPiece.NONE) { | ||
| this.pieceInHand = state.pieceInHand; | ||
| } else { | ||
| this.pieceInHand = null; | ||
| } |
There was a problem hiding this comment.
hmm quelle est l'utilité d'avoir pieceInHand : QuartoPiece | null si on a QuartoPiece.NONE pour représenter l'absence de pièce ?
acieroid
reviewed
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.