🐛 Fix/Improve SPI TFT support on MKS SGEN_L V2.0 #27183
Open
+104
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
thisiskeithb
force-pushed
the
pr/fix_spi_tft_support_s_gen_l_v2
branch
from
c360488
to
67e2b96
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
c792921
to
37fb26b
Compare
thisiskeithb
force-pushed
the
pr/fix_spi_tft_support_s_gen_l_v2
branch
from
67e2b96
to
b5de0e7
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
37d77d6
to
aa44542
Compare
BTT TFT35 SPI and MKS TS35 V2.0 require different pins / settings.
thisiskeithb
force-pushed
the
pr/fix_spi_tft_support_s_gen_l_v2
branch
from
b5de0e7
to
ff4e8bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix/Improve SPI TFT support on MKS SGEN_L V2.0 since BTT TFT35 SPI and MKS TS35 V2.0 require different pins / settings.
Verified with both SPI TFTs on an MKS SGEN_L V2.0.
Note
I discovered an issue with the BTT TFT35 SPI staying/going white if an SD card is inserted at boot or after booting, so I'll have to look into that some more. It shouldn't hold up this PR since it'll be a rare board/screen combination.
Requirements
BTT TFT35 SPI or MKS TS35 V2.0 on MKS SGEN_L V2.0.
Benefits
Fixes/improves SPI TFT support on MKS SGEN_L V2.0.
Related Issues