Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selenium.version changed to 3.4.0 #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

selenium.version changed to 3.4.0 #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bf01c8
selenium.version changed to 3.4.0
Phoi-Hoa-Nguyen Jul 28, 2017
52fd6aa
change lib version to 1.4.0.11-SNAPSHOT
Phoi-Hoa-Nguyen Jul 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<groupId>com.github.markusbernhardt</groupId>
<artifactId>robotframework-selenium2library-java</artifactId>
<version>1.4.0.9-SNAPSHOT</version>
<version>1.4.0.11-SNAPSHOT</version>
<packaging>jar</packaging>

<name>Robot Framework :: Selenium2Library</name>
Expand All @@ -24,7 +24,7 @@
<java.version>1.6</java.version>
<xml.doclet.version>1.0.5</xml.doclet.version>
<robotframework.version>2.9.2</robotframework.version>
<selenium.version>2.48.2</selenium.version>
<selenium.version>3.4.0</selenium.version>
<keywords.class>Selenium2Library</keywords.class>
</properties>

Expand Down
6 changes: 1 addition & 5 deletions src/main/java/com/github/markusbernhardt/selenium2library/keywords/BrowserManagement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1495,11 +1495,7 @@ protected void parseBrowserOptionsFirefox(String browserOptions, DesiredCapabili
Iterator<?> iteratorExtensions = extensions.iterator();
while (iteratorExtensions.hasNext()) {
File file = new File(iteratorExtensions.next().toString().replace('/', File.separatorChar));
try {
firefoxProfile.addExtension(file);
} catch (IOException e) {
logging.warn("Could not load extension: " + file.getAbsolutePath());
}
firefoxProfile.addExtension(file);
}
} else {
logging.warn("Unknown browserOption: " + key + ":" + entry.getValue());
Expand Down