Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to control whether or not the reader will skip empty rows #167

Closed
wants to merge 2 commits into from

Conversation

benplante
Copy link

This PR addresses #164

Add the IgnoreEmptyRows option to the ExcelDataReaderOptions class. Default behaviour is to skip over any empty rows in the spreadsheet until another non-empty row is found or the spreadsheet ends. In some edge cases a spreadsheet may contain a large number of empty rows which can cause calls to the Read() method to take a long time since it is reading over and skipping many rows. Setting this option to false disables will result in the reader returning every row regardless of how many fields the row contains, which means library users may control if the reader continues to read when a row is empty.

@MarkPflug
Copy link
Owner

This PR was incomplete, it didn't contain any tests, nor an implementation for .xls files.
I've completed this feature as PR #168. The option is named 'IgnoreEmptyTrailingRows`, because the library never skipped empty rows that have subsequent rows of data, and that behavior is unchanged.

@MarkPflug MarkPflug closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants