allowsInlinePredictions is now available (#248)

MarkEdit-app · Jul 31, 2023 · 8ea1972 · 8ea1972
1 parent 2eac1c4
commit 8ea1972
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 9 deletions.
diff --git a/MarkEditKit/Sources/Extensions/WKWebViewConfiguration+Extension.swift b/MarkEditKit/Sources/Extensions/WKWebViewConfiguration+Extension.swift
@@ -32,16 +32,25 @@ public extension WKWebViewConfiguration {
       return false
     }
 
-    // [macOS 14] WebKit hasn't yet exposed this as public, even it's documented
-    return responds(to: sel_getUid("setAllowsInlinePredictions:"))
+    #if compiler(>=5.9)
+      return true
+    #else
+      return responds(to: sel_getUid("setAllowsInlinePredictions:"))
+    #endif
   }
 
-  func setAllowsInlinePredictions(_ allowsInlinePredictions: Bool) {
+  func setAllowsInlinePredictions(_ newValue: Bool) {
     guard supportsInlinePredictions else {
       return
     }
 
-    // [macOS 14] WebKit hasn't yet exposed this as public, even it's documented
-    setValue(allowsInlinePredictions, forKey: "allowsInlinePredictions")
+    #if compiler(>=5.9)
+      if #available(macOS 14.0, *) {
+        allowsInlinePredictions = newValue
+        return
+      }
+    #endif
+
+    setValue(newValue, forKey: "allowsInlinePredictions")
   }
 }
diff --git a/MarkEditMacTests/RuntimeTests.swift b/MarkEditMacTests/RuntimeTests.swift
@@ -15,10 +15,11 @@ final class RuntimeTests: XCTestCase {
       return
     }
 
-    // [macOS 14] Remove after WebKit exposes this as public
-    let configuration = WKWebViewConfiguration()
-    configuration.setValue(true, forKey: "allowsInlinePredictions")
-    testExistenceOfSelector(object: configuration, selector: "setAllowsInlinePredictions:")
+    #if compiler(<5.9)
+      let configuration = WKWebViewConfiguration()
+      configuration.setValue(true, forKey: "allowsInlinePredictions")
+      testExistenceOfSelector(object: configuration, selector: "setAllowsInlinePredictions:")
+    #endif
   }
 
   func testExistenceOfDrawsBackground() {