Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix absoluteFrame #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix absoluteFrame #9

wants to merge 2 commits into from

Conversation

larryonoff
Copy link

@larryonoff larryonoff commented Jan 20, 2021 •
edited
Loading

There're cases when UIApplication.shared.delegate?.window == nil

@MarioIannotta
Copy link
Owner

Hi @larryonoff and thanks for your contribution.
It looks like in the PR there're some aesthetic changes that are not really needed, could you revert them? I would like to keep the code base homogeneous.
In addition to that I was wondering what's the case when UIApplication.shared.delegate?.window is nil. It looks like a very edge case 🤔

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larryonoff @MarioIannotta